[Bug 778] Changed - Compiler warnings for wine-20020605

[wine-bugs at winehq.com]

http://bugs.winehq.com/show_bug.cgi?id=778

*** shadow/778	Sun Jun  9 15:24:39 2002
--- shadow/778.tmp.12600	Sun Jun  9 22:35:08 2002
***************
*** 2,8 ****
  | Compiler warnings for wine-20020605                                        |
  +----------------------------------------------------------------------------+
  |        Bug #: 778                         Product: Wine                    |
! |       Status: UNCONFIRMED                 Version: unspecified             |
  |   Resolution:                            Platform:                         |
  |     Severity: normal                   OS/Version: All                     |
  |     Priority: P1                        Component: wine-binary             |
--- 2,8 ----
  | Compiler warnings for wine-20020605                                        |
  +----------------------------------------------------------------------------+
  |        Bug #: 778                         Product: Wine                    |
! |       Status: NEW                         Version: unspecified             |
  |   Resolution:                            Platform:                         |
  |     Severity: normal                   OS/Version: All                     |
  |     Priority: P1                        Component: wine-binary             |
***************
*** 48,50 ****
--- 48,104 ----
  dlls/oleaut32/variant.c:4647: warning: unsigned value < 0 is always 0
  dlls/wininet/internet.c:855: warning: unsigned value < 0 is always 0
  dlls/wininet/internet.c:903: warning: unsigned value < 0 is always 0
+ 
+ ------- Additional Comments From vberon at mecano.gme.usherb.ca  2002-06-09 22:35 -------
+ Not familiar with a bunch of those files, but here's what I'm sure of:
+ 
+ files/file.c:135: warning: unsigned value < 0 is always 0
+ Sent a mail to Martin Wilck for him to check it.
+ 
+ dlls/ntdll/reg.c:229: warning: unsigned value < 0 is always 0
+ The max is always bypassed. The three types involved are two size_t and a ULONG
+ Not familiar with the functionality. No patch yet from me.
+ 
+ dlls/gdi/freetype.c:712: warning: unsigned value < 0 is always 0
+ dlls/shlwapi/ordinal.c:2458: warning: unsigned value < 0 is always 0
+ dlls/shlwapi/ordinal.c:2473: warning: unsigned value < 0 is always 0
+ dlls/shlwapi/shlwapi_main.c:63: warning: unsigned value >= 0 is always 1
+ Comparison of a DWORD < 0, or DWORD >= 0. A value of -1 indicates failure. No
+ patch yet from me. Probably some type changes needed, or a cast.
+ 
+ dlls/ole32/hglobalstream.c:614: warning: unsigned value < 0 is always 0
+ Involves LARGE_INTEGER arithmetics. Test probably broken, but no proof yet.
+ 
+ dlls/shlwapi/ordinal.c:1163: warning: unsigned value < 0 is always 0
+ Not sure which function is really called (hence, no clue about the validity of
+ the construction).
+ 
+ dlls/oleaut32/typelib.c:4586: warning: unsigned value >= 0 is always 1
+ dlls/oleaut32/typelib.c:4819: warning: unsigned value >= 0 is always 1
+ UINT verified for >= 0. Might be removable, not sure. No patch yet from me.
+ 
+ dlls/comctl32/listview.c:1835: warning: unsigned value >= 0 is always 1
+ dlls/comctl32/listview.c:1838: warning: unsigned value >= 0 is always 1
+ Addition of a DWORD and an int gives an unsigned int. Patch submitted to
+ wine-patches.
+ 
+ dlls/x11drv/winpos.c:1405: warning: unsigned value >= 0 is always 1
+ BAD!!! Continuation condition of a for is always 1. Patch submitted to wine-patches.
+ 
+ dlls/advapi32/crypt.c:845: warning: unsigned value < 0 is always 0
+ dlls/advapi32/crypt.c:1132: warning: unsigned value < 0 is always 0
+ controls/button.c:201: warning: unsigned value < 0 is always 0
+ dlls/ole32/oleobj.c:291: warning: unsigned value < 0 is always 0
+ dlls/ole32/oleobj.c:650: warning: unsigned value < 0 is always 0
+ dlls/oleaut32/variant.c:3935: warning: unsigned value < 0 is always 0
+ Comparison of a DWORD or UINT parameter < 0. Seems the specific test can be
+ safely removed. Patch submitted to wine-patches.
+ 
+ dlls/oleaut32/variant.c:4035: warning: unsigned value < 0 is always 0
+ dlls/oleaut32/variant.c:4647: warning: unsigned value < 0 is always 0
+ dlls/wininet/internet.c:855: warning: unsigned value < 0 is always 0
+ dlls/wininet/internet.c:903: warning: unsigned value < 0 is always 0
+ Type wasn't suited for the task. Patch submitted to wine-patches.
+ 
+ I don't take ownership of this bug, as I'm not familiar enough with the balance
+ of the various issues.
\ No newline at end of file