[Bug 1240] - Nullsoft Installer has bad child window style on first screen

[wine-bugs at winehq.com]

http://bugs.winehq.com/show_bug.cgi?id=1240

andi at rhlx01.fht-esslingen.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
      everconfirmed|0                           |1



------- Additional Comments From andi at rhlx01.fht-esslingen.de  2003-01-26 18:36 -------
The only place in Wine to fix up WS_CAPTION is:

    /* Correct the window style - stage 2 */

    if (!(cs->style & WS_CHILD))
    {
        wndPtr->dwStyle |= WS_CLIPSIBLINGS;
        if (!(cs->style & WS_POPUP))
        {
            wndPtr->dwStyle |= WS_CAPTION;
            wndPtr->flags |= WIN_NEED_SIZE;
        }
    }

in windows/win.c/WIN_CreateWindowEx()

Checking windows/win.c cvs log, I'm thinking about:

----------------------------
revision 1.214
date: 2003/01/08 19:53:47;  author: julliard;  state: Exp;  lines: +2 -2
Duane Clark <dclark at akamail.com>
WS_CAPTION is a two bit field, so test appropriately.
----------------------------
Hmm, could it be that this recent change caused you to notice the WS_CAPTION
problem ?

The WS_CAPTION fixup has been in windows/win.c since its CVS beginnings, BTW.

I think we can safely confirm this bug.

So the question is: what exactly should be corrected in that function and how ?

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://bugs.winehq.com/show_bug.cgi?id=1240>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.