[Bug 889] WINPOS_GetWinOffset() yields wrong offset

[Wine Bugs]

http://bugs.winehq.com/show_bug.cgi?id=889





------- Additional Comments From z_god at wanadoo.nl  2003-20-06 08:06 -------
Bug comments restored from Gmane.org: 
 
Using the game Dynomite from PopCap Games works very well except that the offset 
for the graphics is the same as the offset of the window (on the desktop) in 
which the graphics are being displayed; I essentially eliminated the code in 
WINPOS_GetWinOffset() by adding a return immediately following the code that 
sets of the X and Y component of the offset to 0 -- this solves the problem but 
I suspect that it will cause problems elsewhere; the file of interest is 
windows/winpos.c; feel free to contact me for any additional information 
 
 
------- Additional Comments From tuiningas_ml <at> shaw.ca  2002-07-21 00:26 ------- 
I followed the trail a little bit 
further as I noticed that "hot spots" on an image (like buttons) would 
fade in and out when the window wasn't at the top left of the screen. 
The trail led to the file dlls/x11drv/winpos.c. It is making a call to 
MapWindowPoints() which in turn calls WINPOS_GetWinOffset(). If I 
eliminate the call to MapWindowPoints() in the function expose_window() 
at line 290, (and restore the original version of windows/winpos.c) 
everything works beautifully. The window draws itself properly and the 
buttons work as expected. I am not all that familiar with Wine code, 
though, so can anyone think of a good reason why this code ought to be 
there? Should I submit a patch? And if so, can anyone point me to the 
method required for doing so? Thanks. 
 
 
------- Additional Comments From tony_lambregts <at> telusplanet.net 2002-07-21 
09:59 ------- 
I am not that familiar with wine internals either, but if you submit a patch to 
wine_patches <at> winehq.com, I'm sure that if there is something wrong with it 
someone will point it out. 
 
The following links are from the Wine Developers Guide on how to submit patches 
 
http://www.winehq.com/Docs/wine-devel/patches.shtml 
http://www.winehq.com/Docs/wine-devel/patch-quality.shtml 
 
 
------- Additional Comments From tuiningas_ml <at> shaw.ca  2002-07-23 21:42 ------- 
Created an attachment (id=239)
 --> (http://bugs.winehq.com/attachment.cgi?id=239&action=view) 
Proposed patch for this ug 
 
 
------- Additional Comments From tony_lambregts <at> telusplanet.net 2002-07-24 
10:26 ------- 
I applied your patch to my system and tested it with several programs and the 
results are not very good. the startup screen of winzip is totally corrupted by 
this patch. 
 
 
------- Additional Comments From tony_lambregts <at> telusplanet.net 2002-07-24 
10:30 ------- 
Created an attachment (id=240)
 --> (http://bugs.winehq.com/attachment.cgi?id=240&action=view) 
Screen shot showing corruption of Winzip startup screen. 
 
 
------- Additional Comments From tuiningas_ml <at> shaw.ca  2002-07-24 22:42 ------- 
The proposed patch that I made was wrong but it seems that someone else made the 
right patch elsewhere so it is now fixed. I guess the moral of the story is: if 
you wait long enough, someone else will do it for you.... :-) 
 
 
------- Additional Comments From tony_lambregts <at> telusplanet.net 2003-03-26 
15:20 ------- 
Closing 

-- 
Configure bugmail: http://bugs.winehq.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.