[Bug 1312] compilation problem on NetBSD (*BSD?)

Wine Bugs wine-bugs at winehq.com
Sun Jun 22 10:30:27 CDT 2003


http://bugs.winehq.com/show_bug.cgi?id=1312





------- Additional Comments From fsteinel at flonet.net  2003-22-06 10:30 -------
Bug comments restored from Gmane.org: 
 
dlls/ntdll/cdrom.c does not compile on NetBSD, because it expects CD_FRAMES,
CD_SECS, and CDROM_MSF to be defined in some system header.
On Linux, they seem to be in <linux/cdrom.h>, but they are not defined on
NetBSD at all.
I'll attach a patch that makes it compile again.
This patch also ifdef's out a debugging message that uses some fields of a
structure which also don't exist on NetBSD.


------- Additional Comments From wiz <at> danbala.ifoer.tuwien.ac.at 2003-03-08
02:16 -------
Created an attachment (id=418)
 --> (http://bugs.winehq.com/attachment.cgi?id=418&action=view)
compilation fix as mentioned in the bug report


------- Additional Comments From andi <at> rhlx01.fht-esslingen.de  2003-03-08
03:05 -------
'scuse me, I don't see that
TRACE("caching toc from=%d to=%d\n", hdr.cdth_trk0, hdr.cdth_trk1);
line in newest CVS.
Are you running CVS?
If not, does CVS fix anything?

Err no, you're not.

Current CVS has some half-fix. Could you update and patch the remaining missing
parts (CDROM_MSF etc.) instead?
Thanks for the report!


------- Additional Comments From wiz <at> danbala.ifoer.tuwien.ac.at 2003-03-08
07:41 -------
ok, the CD_SECS and CD_FRAMES as well as the debug line are fixed in CVS.
The CDROM_MSF is only used once outside of the #ifdef linux part -- I guess
that's an error and just shouldn't be there.

Additionally, I stumbled over a duplicate assignment around line 920:
        data->MediaCatalog.FormatCode = IOCTL_CDROM_MEDIA_CATALOG;
        data->MediaCatalog.FormatCode = sc.what.media_catalog.data_format;
One of them should probably go...

-- 
Configure bugmail: http://bugs.winehq.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the wine-bugs mailing list