[Bug 10649] Regression in RegQueryValueExA when called in unorthodox manner

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=10649


Juan Lang <juan_lang at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |juan_lang at yahoo.com




--- Comment #8 from Juan Lang <juan_lang at yahoo.com>  2007-12-11 17:22:13 ---
(In reply to comment #6)
> The problem with the second test is that I don't know what Windows does and
> can't test it.  It could easily vary between versions.

That's true.  You can always ask for help testing patches on wine-devel.  On
your patch:

-    DWORD total_size;
+    DWORD total_size, datalen;
(snip)
+    if (count) datalen = *count;
(snip)
-                if (len > *count) status = STATUS_BUFFER_OVERFLOW;
+                if (len > datalen) status = STATUS_BUFFER_OVERFLOW;

This can fail, datalen isn't initialized in all branches.  You need to fix
that.  Same with the other two changes.

Also, patches won't be picked up here - you'll want to send them to
wine-patches.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.