[Bug 8936] openCanvas does not start properly

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=8936





--- Comment #23 from Alex Balut <alexandru.balut at gmail.com>  2007-12-21 19:30:12 ---
(In reply to comment #22)
> Created an attachment (id=9742)
 --> (http://bugs.winehq.org/attachment.cgi?id=9742) [details]
> patch v2
> 
> Umm.. so yeah, I'm a C beginner :)
> But at least I realized how stupid my previous patch was. So here's another
> one.
> 

Thanks for finding the problem!

We need:

wintab_internal.h:
// comment explaining the meaning of this value ... 
// (159 chars + 2 fuzzy brackets + 1 endline)
#define MAX_DUMPBITS_LENGTH 162


tests/context.c:
A test function that fills a buffer of size MAX_DUMPBITS_LENGTH with '\0' and
then calls DUMPBITS(0xFFFFFFFF, buf). I'm not a C specialist myself, it would
be nice to calculate dynamically 0xFFFFFFFF in case sizeof(int) varies. The
actual test would be to check that 
buf[MAX_DUMPBITS_LENGTH - 2] == '}' && 
buf[MAX_DUMPBITS_LENGTH - 1] == '\0'
If you need help setting up the tests directory, tell me when you get stuck, I
will try to help.

context.c:
Use the new define instead of "200".
Regarding DUMPCONTEXT, it should be refactored to get rid of the "4000" value,
but that should be a different patch. 

What do you think?


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.