[Bug 5114] suggesting more descriptive desktop window titles

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=5114


Jeff Zaroyko <jeffzaroyko at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeffzaroyko at gmail.com




--- Comment #6 from Jeff Zaroyko <jeffzaroyko at gmail.com>  2008-02-11 17:57:43 ---
(In reply to comment #5)
> (In reply to comment #4)
> > Created an attachment (id=10710)
 --> (http://bugs.winehq.org/attachment.cgi?id=10710) [details] [details]
> > Patch to add requested functionality
> 
> You got the basic idea right, but the code needs some additional work, i.e.
> don't mix WCHARs and chars.
> 


additional to the above

+        char windowname[strlen(desktop_nameW) + strlen(desktopname)];

variable length arrays are a C99 feature wine uses C89, and I don't think you
have allocated enough space to store the two strings, dynamically allocate the
storage and include space for the nul terminator.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.