[Bug 11763] New: Bug fix and small improvement of function MSVCRT_fputc in dlls/msvcrt/file .c.
wine-bugs at winehq.org
wine-bugs at winehq.org
Thu Feb 28 10:15:59 CST 2008
http://bugs.winehq.org/show_bug.cgi?id=11763
Summary: Bug fix and small improvement of function MSVCRT_fputc
in dlls/msvcrt/file.c.
Product: Wine
Version: CVS/GIT
Platform: All
OS/Version: All
Status: UNCONFIRMED
Severity: enhancement
Priority: P3
Component: msvcrt
AssignedTo: wine-bugs at winehq.org
ReportedBy: pawel.ludwiczak at gmail.com
Created an attachment (id=11023)
--> (http://bugs.winehq.org/attachment.cgi?id=11023)
Proposed solution
Bug fix:
In Function MSVCRT_fputc from dlls/msvcrt/file.c, if there are no errors, the
same character that has been written should be returned, but the value should
be converted to an 'unsigned char' before will be returned. Otherwise e.g. if
input character = 0xffffffff, the returned value will not equal to 0xff, we
will
get EOF instead.
Small improvement:
In my opinion, the function MSVCRT_fputc flushes a buffer when get '\n' and it
is OK, but when the file is opened in binary mode this behaviour is unnecessary
and decrease efficiency.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
More information about the wine-bugs
mailing list