[Bug 14666] [wined3d] volume/volumetex locking implementation

wine-bugs at winehq.org wine-bugs at winehq.org
Sun Jul 27 18:55:13 CDT 2008


http://bugs.winehq.org/show_bug.cgi?id=14666





--- Comment #11 from Stefan Dösinger <stefandoesinger at gmx.at>  2008-07-27 18:55:12 ---
I think this is better handled on wine-devel, but I am not sure about the
policies.

I'd recommend you to get the tests in first(with todo_wine markers for failing
tests). The tests look pretty good to me, just that you should use the return
value you got from D3D for error handling, not the expected value. E.g.

hr = Volume_Lock(vol);
ok(hr == expected, ...);
if(expected) { <--- Change this to hr
    unlock();
}

Once you have the volume tests in, you can port them over to textures and
cubetextures, and probably plain surfaces, and then port the texture and
cubetexture tests to ddraw to see how things work there. Once we know how ddraw
behaves we can make a more solid decision how to implement the behavior
properly in wine.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.


More information about the wine-bugs mailing list