[Bug 12083] ok() test doesn't support nested calls

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=12083


Dmitry Timoshkov <dmitry at codeweavers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #3 from Dmitry Timoshkov <dmitry at codeweavers.com>  2008-03-17 23:43:13 ---
(In reply to comment #2)
> Does this mean that nested ok() calls are not allowed?

It was not designed for recursive calls, so, yes, all the instances
that cause recursive ok() calls should be fixed.

> I wasn't worried
> specifically about that FinishNotificationThread() call, but just giving it as
> an example. Unfortunately, it looks like there are hundreds of such nested
> calls in the code (a quick test gave me ~1500, and that didn't even finish
> because some of the tests crashed before they could all run). Do all such
> instances need to be changed? If so, should there also be a recursion
> check/assert to winetest_set_location() and winetest_ok()?

It's not worth it IMO.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.