[Bug 12979] Trucks&Trains game error in quartz.dll

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=12979





--- Comment #3 from Olivier Samyn <olivier-ml1 at oleastre.be>  2008-05-06 18:12:29 ---
I located the problem. In the following code from dlls/quartz/filesource.c,
sometimes, *pin is null (ie This->pOutputPin).


I just added a return S_FALSE in that case and it works again for me.

Small patch below:

diff --git a/dlls/quartz/filesource.c b/dlls/quartz/filesource.c
index f410b56..a4e708f 100644
--- a/dlls/quartz/filesource.c
+++ b/dlls/quartz/filesource.c
@@ -533,6 +533,10 @@ static HRESULT AsyncReader_GetPin(IBaseFilter *iface,
ULONG
         return S_FALSE;

     *pin = (IPin *)This->pOutputPin;
+    
+    if(!(*pin))
+        return S_FALSE;
+    
     IPin_AddRef(*pin);
     return S_OK;
 }


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.