[Bug 12349] DSOUND_MixInBuffer Assertion `dsb->buf_mixpos + len <= dsb-> tmp_buffer_len' failed

wine-bugs at winehq.org wine-bugs at winehq.org
Mon May 19 11:04:48 CDT 2008


http://bugs.winehq.org/show_bug.cgi?id=12349





--- Comment #11 from Jörg Höhle <hoehle at users.sourceforge.net>  2008-05-19 11:04:48 ---
Rethinking comment #4, I found good reasons to prefer
for (i = 3; i < len;   i += 4)
over
for (i = 0; i < len-3; i += 4)
because the former works with both signed and unsigned integer types.
The latter only works reliably with signed integers. Luckily, len and i are
signed (INT), so it's ok here.

With unsigned integers, imagine len were 2, len-3 (=0xffffffff) would defeat
the end test and loop a billion times.

Alas, the patch has not appeared in 0.9.60, .61 nor in 1.0rc1, despite posting
twice to wine-patches. I'll have to find out what's "Not Obviously Correct".


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.


More information about the wine-bugs mailing list