[Bug 13112] comctl32 trackbar setPos() should not call oncustomdraw if value hasn't changed

wine-bugs at winehq.org wine-bugs at winehq.org
Sun Sep 28 10:10:24 CDT 2008


http://bugs.winehq.org/show_bug.cgi?id=13112





--- Comment #5 from Josep Ma <jaz at pastnotecut.org>  2008-09-28 10:10:23 ---
I don't know how to test this. The current tests check that the call produces a
specific result.

In this case, what matters is the call the function itself does to Invalidate,
which is not required. This doesn't change the trackbar in itself, so I
wouldn't know how to test if that call is executed or not.

I found the bug since I was calling it repeatedly with the same value and that
caused some side effects in my application. Or maybe is precisely the
invalidate code the one that should be investigated.

I opted to post it as a patch since it seemed the easy way to get it fixed, but
now i'm doubtful about it.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list