[Bug 15388] gdi32: dib.c fails to build with gcc 4.2, -Werror -O3

wine-bugs at winehq.org wine-bugs at winehq.org
Tue Sep 30 01:17:02 CDT 2008


http://bugs.winehq.org/show_bug.cgi?id=15388





--- Comment #7 from Andrey Turkin <andrey.turkin at gmail.com>  2008-09-30 01:17:02 ---
Uhm... After re-reading sources this error actually looks like false positive
as we already know DIB_GetBitmapInfo will work if we get to its call (because
of succeed CreateDIBSection). Probably too complicated for compiler's little
brain :)
However, in any other case this patch would be wrong because of introduced
resource leaks (DIB section was already created). I can see two ways - either
silence compiler like your original patch did, or pretend this is not false
positive and move DIB_GetBitmapInfo call up to very function beginning.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list