[Bug 19495] DialogBox() returns -1 for Invalid Window Handle, Should Be 0

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=19495


robertgonder at embarqmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
         Resolution|INVALID                     |




--- Comment #11 from robertgonder at embarqmail.com  2009-08-04 14:24:53 ---
(In reply to comment #8)
> It's unfortunate that your "test framework" doesn't test anything, and
> contains so much errors. Have you tried it at least compile, I don't even
> mention to run?

I don't have your test harness.
My test code was compiled with BCB 5.5 and then modified to fit into your
framework as best as I could understand it.

I tested everything in the DlgProc.
I tested everything in the TestProc except for
1) The dialog resource which I just reused one from another test case, as all I
needed was a valid dialog.
2) I guessed at the functionality of ok().

It does test the bug.
How does it "not test anything" ?

The bug is in the return value of DialogBox when an hWindow of 0 is passed.
The DlgProc closes the dialog as soon as it opens. This automates the user
pressing a close button. We aren't interested in what the dialog does.
The interesting item is the return value of -1, when it should be 0.

>NULL is not an invalid window handle as the reporter
>of the bug implies, and the "test case" is broken.

According to the docs, NULL is invalid, and a special case has been made to
return a 0 instead of -1 in that case.
Are you saying that DialogBox( inst, resource, NULL, proc ) is now returning 0?
The version of Wine I have here clearly returns -1 and errorcode of 1400.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.