[Bug 19759] SLTG_ReadString does not null terminate

wine-bugs at winehq.org wine-bugs at winehq.org
Mon Aug 17 11:21:25 CDT 2009


http://bugs.winehq.org/show_bug.cgi?id=19759





--- Comment #6 from Sunil Mohan Adapa <sunilmohan at fsf.org.in>  2009-08-17 11:21:25 ---
(In reply to comment #5)
> Patches should be sent to wine-patches, they're not picked up from here. 

Thank you for mentioning, I shall send it to the list.

> The
> correction to SLTG_ReadString looks fine, though I agree with Vitaliy that the
> change to SLTG_DoVars looks more suspect.

Change to SLTG_DoVars, strictly speaking, is not required given that Wine's
implementation of SysAllocStringLen is zero-filling the buffer. However, I
think the change is good to have, as this behaviour is not guaranteed (by other
implementations?). 

So, then, shall I remove both the NULL terminations from the patch?

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list