[Bug 17290] DOSBox installer crashes on launch

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=17290





--- Comment #4 from Dylan Smith <dylan.ah.smith at gmail.com>  2009-02-07 02:12:50 ---
(In reply to comment #3)
> Damn, that was quick. I was just posting the regression test results...:
> 
> austin at austin-desktop:~/wine-git$ git bisect bad
> ea9e062b6c460b17ddc3b820dee80960b74b9369 is first bad commit
> commit ea9e062b6c460b17ddc3b820dee80960b74b9369
> Author: Dylan Smith <dylan.ah.smith at gmail.com>
> Date:   Fri Feb 6 01:09:36 2009 -0500
> 
>     richedit: Removed unnecessary calls to ME_WrapMarkedParagraphs.
> 
>     These calls to ME_WrapMarkedParagraphs never do anything, and don't make
>     sense to be called in these places. These places are for ME_MoveCaret,
>     and ME_ArrowHome, which both don't involve any text being modified, and
>     all (direct and indirect) calls to these functions are done after the
>     text has already been wrapped.
> 
> :040000 040000 45e465b6c983b8fe6546963a7c0ffc745a3d4b10
> ba718734b4ee94514e23952dca8388c6284b943a M      dlls
> 
> Patch works great. Thanks!
> 

Seems like the problem in WM_SETFONT and EM_SETRECTNP were there before, but
the unnecessary wrapping that was removed was preventing the assertion failure.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.