[Bug 17431] New: SPY_DumpMem shouldn't crash when given an invalid pointer

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=17431

           Summary: SPY_DumpMem shouldn't crash when given an invalid
                    pointer
           Product: Wine
           Version: 1.1.15
          Platform: Other
               URL: http://test.winehq.org/data/3fa05ae6a7c08f9534badfeffbe0
                    2db9e00ab47a/wine_xp_ae-ub810-all/comctl32:datetime.html
        OS/Version: other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: user32
        AssignedTo: wine-bugs at winehq.org
        ReportedBy: madewokherd at gmail.com


The linked test was run by Austin English with WINEDEBUG=+all.

The line in the test that caused the crash was probably this one, or a similar
line:
http://source.winehq.org/git/wine.git/?a=blob;f=dlls/comctl32/tests/datetime.c;hb=3fa05ae6a7c08f9534badfeffbe02db9e00ab47a#l43

The test is sending DTM_SETMCCOLOR, which has lParam as a COLORREF.
SPY_DumpStructure is checking for several LVM_ messages that have a pointer in
lParam. Apparently, DTM_SETMCCOLOR has the same value as one of those other
symbols, and our message spy code can't tell the difference.

I don't think we can avoid this situation, but it shouldn't crash. SPY_DumpMem
should be able to catch page faults.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.