[Bug 8224] Adobe Lightroom 1.0 won't let you create a database

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=8224





--- Comment #13 from Saulius K. <saulius2 at gmail.com>  2009-01-19 12:01:18 ---
In reply to Simon Kirby:

> The patch has still not been merged in git head, which I suspect is because the 
> patch does not remove the stub "FIXME" and has this comment:

I found an old comment of Michael Karcher from wine-devel mailing list more
reasonable:

> The idea of your patch looks right to me. But (1) please don't use memcmp to 
> compare wide characters, especially, don't use memcmp with a count of one, as 
> it only compares one half the the wide character. use 
>   filename[1] == ':' && filename[2] == '\\'
> instead. (2) Please check that filename really has at least 3 characters before 
> accessing it. (3)Please check the size of the output buffer before copying 
> anything into it.
> 
> Finally, the chance of getting this patch accepted raises if you accompany the 
> implementation with an API test. Another point to increase the chances of 
> getting that patch committed is to implement the corner cases (at least the 
> empty string) explained on MSDN, also backed up by an API test. Please also 
> note the documented behaviour for the case of the output buffer being short by 
> one byte.

So, the patch needs to be rewritten a bit plus has to include minimal test.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.