[Bug 17908] New: TCSCP fails to install

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=17908

           Summary: TCSCP fails to install
           Product: Wine
           Version: 1.1.18
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msi
        AssignedTo: wine-bugs at winehq.org
        ReportedBy: wine at mkarcher.dialup.fu-berlin.de
                CC: truiken at gmail.com


The TCSCP installer fails to accept valid license numbers. This has been
tracked down to be caused by

commit 8321276cd34486bc6bf1e07c0e99c73423288854
Author: James Hawkins <truiken at gmail.com>
Date:   Wed Oct 18 11:25:14 2006 -0700

    msi: Run SetProperty events before all other events no matter what the
order is.

The reason is, that there is an action table for the next button of the dialog
where you enter user name / company name / license code along these lines:

"UserInfoDlg" "Next" "[numtocheck]" "[keyentered]" "FEATURE_A = 1 OR "FEATURE_B
= 1" 1
"UserInfoDlg" "Next" "[checkpassed]" "0" "1" 15
"UserInfoDlg" "Next" "DoAction" "CheckLicenseString" "FEATURE_A = 1 OR
FEATURE_B = 1" 20
"UserInfoDlg" "Next" "[donotinstall]" "1" "NOT checkpassed" 100

Because that patch executes the PropertySet Actions before all other actions,
donotinstall always gets set to 1, even if the entered license number is
correct (in that case, the custom action "CheckLicenseSting" will set
checkpassed to one, if the number in numtocheck is valid). Having donotinstall
set to one makes the installer re-request a valid license number. Reverting the
patch (and thus executing the custom action at the right point in time fixes
the behaviour. The correct fix for Americas Army that needed this out-of-order
execution thus must be different.

The installer has been verified to work fine in Windows XP.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.