[Bug 13394] gtk-dev-2.12.9-win32-2.exe crashes on installation

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=13394





--- Comment #25 from Juan Lang <juan_lang at yahoo.com>  2009-10-07 17:12:59 ---
The patch never got feedback and never got applied, either.  Nikolay, would you
mind resending?  I have a couple style nits I'll point out here though:

+    WCHAR currd[MAX_PATH];
You don't need to declare this in the topmost scope, you can declare it here
instead:
+    {
+        GetCurrentDirectoryW(MAX_PATH, currd);

Backing up a line,

+    if ((lpFileOp->wFunc == FO_COPY) &&
+        (lpFileOp->pTo[0] == 0))
I think !lpFileOp->pTo[0] is preferred style to comparing against 0.

Finally,

+    else
     if (lpFileOp->wFunc != FO_DELETE)
Leaving the else on its own line looks funny to me.  Better would be:
+    else if (lpFileOp->wFunc != FO_DELETE)
-    if (lpFileOp->wFunc != FO_DELETE)

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.