[Bug 19352] Windows Live Messenger 2009 installer doesn't start

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=19352


Louis Lenders <xerox_xerox2000 at yahoo.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |xerox_xerox2000 at yahoo.co.uk
     Ever Confirmed|0                           |1




--- Comment #1 from Louis Lenders <xerox_xerox2000 at yahoo.co.uk>  2009-10-24 14:13:14 ---
)
> 
> Commenting out SetLastError in FormatMessageW helps go further, but then it
> will complain about it cannot download setup.

Confirming. Instead of commenting out the SetLastError, the installer proceeds
as well if you set lasterror to ERROR_RESOURCE_TYPE_NOT_FOUND. 

The ERROR_RESOURCE_LANG_NOT_FOUND in current code looks obviously quite wrong
to me, as the code above this line doesn't handle anything languagespecific
things. This of course needs testcase


After this bug, there's a bug in winhttp, using native winhhtp it then crashes 

diff --git a/dlls/kernel32/format_msg.c b/dlls/kernel32/format_msg.c
index e8f9fbc..95a6df2 100644
--- a/dlls/kernel32/format_msg.c
+++ b/dlls/kernel32/format_msg.c
@@ -408,7 +408,7 @@ DWORD WINAPI FormatMessageW(

         if (!from)
         {
-            SetLastError (ERROR_RESOURCE_LANG_NOT_FOUND);
+            SetLastError (ERROR_RESOURCE_TYPE_NOT_FOUND);
             return 0;
         }
     }

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.