[Bug 20164] Regression : Icons incorrectly rendered in RSTAB

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=20164





--- Comment #6 from max at veneto.com  2009-09-26 17:28:57 ---
(In reply to comment #5)
> ...... Did
> this regression occur in 1.1.30 or did it occur earlier as well? Since I added
> X11DRV_XRender_GetSrcAreaStretch a couple of release ago.
> 
> Thanks,
> Roderick

Hi Roderick,

the regression occurred exactly on the patch pointed on the bug report. I
didn't notice before because I was using an old build on these days... no time
to test new releases because of my job :-(
Anyways, I just updated, noticed the regression and made a regression testing
from 1.1.19 to 1.1.30, which pointed me to your patch.
I can't test more in depth right now, I hope I'll have more time on next
days...

I stumbled over a similar problem when I was developing the DIB engine using
the old approach of the mixed pysdev pointers some months ago, and (IIRC) it
was due to mixed blt's between dib engine managed stuff and x11drv ones.
If you look at icons, you can see that some of them are just slightly shifted,
others are completely wrong, so I guess your source bitmap used in blitting is
wrong somehow.
My (old) similar problem was because (IIRC) x11drv has an internal PIXMAP copy
of DIB, (in some kind of linked list ? don't remember...) which was not there
on DIBs managed by my engine. On mixed blitting winex11.drv was reading the
(non-existent) pixmap internal copy instead of the true dib content, which was
of course not the desired effect..... BTW, that's the main reason because my
engine is slower than original on mixed blits; it must convert dib to ddb and
pass it to winex11, as using DIB directly doesn't work because of the missing
internal PIXMAP buffer. 

Ah, obviously I tested it on vanilla wine, without my engine, to be sure it was
not due to it :-)
About RSTAB, there is a demo on www.dlubal.com, but now it's on 7.xx version
and I'm using the 5.xx one.... don't know if bug is present on new one.

Ciao

Max

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.