[Bug 20204] New: MacOS: enhanced metafile retrieval fails and crashes clipboard test

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=20204

           Summary: MacOS: enhanced metafile retrieval fails and crashes
                    clipboard test
           Product: Wine
           Version: 1.1.25
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: ole32
        AssignedTo: wine-bugs at winehq.org
        ReportedBy: hoehle at users.sourceforge.net
                CC: huw at codeweavers.com


Huw Davies' post 1.1.24 commit 7490f922e0adaacbf5396cf8afdc90e33bc1a808
"test for enhanced metafile retrieval" fails on MacOS.
After a variable amount of output about getdata and next, I see
clipboard.c:1356: Test failed: got 80004005
clipboard.c:1358: Test failed: got 0

Alas, the testsuite randomly crashes afterwards, because ReleaseStgMedium() is
not called only if(SUCCEEDED(hr)).  In fact, n-1 occurrences of
ReleaseStgMedium in that file are not guarded.  Therefore, the actual error was
not spotted until now.

Curiously, gcc -O0 tests/clipboard.c tends to crash less or show no crash
dialog at all.  That may explain why using winetest.exe did not spot this
defect earlier.  Sometimes test runs report no failure, it's just the missing
summary line that reveals the problem.

With the guard in place, the testsuite always runs to completion (with the
above 2 errors out of 381 tests).

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.