[Bug 11848] Provide a Clipboard Viewer replacement (clipbrd.exe) used by Adobe Acrobat Pro 6 & 7 / Acrobat Reader 3 - 7

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=11848





--- Comment #30 from Alexander Scott-Johns <alexander.scott.johns+winebug at googlemail.com>  2010-01-29 21:57:08 ---
(In reply to comment #29)
> (In reply to comment #28)
> > Created an attachment (id=25952)
 --> (http://bugs.winehq.org/attachment.cgi?id=25952) [details] [details]
> > New version of clipboard viewer, as one uncompressed patch
> 
> At a glance here is some general feedback without taking too close a look at
> what the code actually does.
> 
> +            // latin1 for now
> +    // Formats are commented out if other, better formats are synthesized
> +    // from them, or the format is broken in Wine.
> 
> You'll want to drop the C99 or C++ style comments.

All the C++ comments are notes-to-self, and will be removed once I've worked
out the correct behaviour.

> 
> +static WCHAR* heap_MBtoWCZ(UINT codepage, LPCSTR src, SIZE_T size_src)
> +{
> +    int len = MultiByteToWideChar(codepage, 0, src, (int) size_src, NULL, 0);
> +    WCHAR* dest = HALLOC(len+1, WCHAR);
> 
> Mixing code and declarations, this is C99 or C++, for Wine you will need
> to put the declarations at the start of a block followed by code.

I thought C89 allowed you to do:

{
    type1 var1 = expr1;  /* decl */
    type2 var2 = expr2;  /* decl */
    stmt1;
    stmt2;
    ...
}

Thanks for the comments.

PS
How do you get the correct dimensions of an EMF? And the correct DC to draw it
in?

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.