[Bug 6971] Mouse "escapes" window or is confined to an area in the full screen program NO HACKS PLEASE
wine-bugs at winehq.org
wine-bugs at winehq.org
Mon Jul 19 19:59:47 CDT 2010
http://bugs.winehq.org/show_bug.cgi?id=6971
ultrageek.lloyd at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ultrageek.lloyd at gmail.com
--- Comment #385 from ultrageek.lloyd at gmail.com 2010-07-19 19:59:44 ---
(In reply to comment #351)
> Created an attachment (id=29313)
--> (http://bugs.winehq.org/attachment.cgi?id=29313) [details]
> Xi2 patch with xorg bug workaround
>
> Here is another patch that works around xorg bug. Try with with. Make sure you
> do have Xorg 1.8 (aka 7.5).
Tested and confirmed working with Xorg 1.8.1.902 and latest wine git, using
Mass Effect 2 as the test case. I was actually just looking into this with the
intent to fix it. Guess you beat me to it :P Nice work in any case.
My only gripe with the patch is the profusion of magic numbers. I would
suggest using #define's to make the code more readable and more robust, but it
looks like that is not common practice in the wine code base. One other
thought is that it might be a good idea to translate the rest of the dinput API
implimentation to XInput2. It seems like there is already a pretty
straightforward 1:1 correspondence between a lot of the dinput functions and
XInput2 functions.
Just my 2 cents. Thanks for the patch, and keep up the good work. Now off to
play some ME2
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
More information about the wine-bugs
mailing list