[Bug 22918] Ship Simulator 2008 demo crashes on startup (needs D3DXCreateSphere, D3DXCreateCylinder, and D3DXCreateTeapot)

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=22918





--- Comment #50 from Tony Wasserka <tony.wasserka at freenet.de>  2010-07-28 13:13:53 ---
(In reply to comment #49)
> Thank you for your comments.
> 
> Just wanted to note I talked to Henri today about this and he believes
> declarations are probably the way to go as this is used internally by wined3d.
> 
> He pointer me to:
> ConvertFvfToDeclaration() in wined3d
> 
> but he mentioned that even if this was submitted as a patch today, it would not
> get in.
> 
> Thus, he wants to see a _perfect_ implementation.
> 
> I have (very briefly) looked at the version in your repo, but I will most
> likely try to make one de novo as Henri seems to have very high standards
> regarding a D3DXFVFToDeclaration function (I don't mean to say your function
> isn't good enough - and I'm pretty sure mine won't be either if existing
> functions in wine git are not good enough - but if I am going to have to revise
> it 8-9 times it is easier for me to start from scratch and perhaps input parts
> from yours later).
> 
> Anyway I appreciate all your feedback and all your hard work.
> 
> Thank you
> Misha

My implementation of D3DXFVFToDeclaration is mostly just a copy-paste of
ConvertFvfToDeclaration anyway (although the latter one has been modified a bit
meanwhile), so it doesn't really matter which one you chose as a guide or if
you chose none at all :P
I guess it'd be better to implement that function stepwise though.. like "first
patch supports position and color elements" "second supports texture
coordinates" "third supports ..."; especially since you'll have to write tests
for all of this stuff :/ (I have written some already, but one could test more
specifically instead of in a all-in-one fashion like I did)

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.