[Bug 421] Implement a DIB engine

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=421





--- Comment #365 from Gustavo <gugamilare at gmail.com>  2010-05-25 15:52:52 ---
(In reply to comment #364)
> (In reply to comment #363)
> > Ok, I've redone the regression test. It seems I had forgotten to patch the
> > source in the last 2 tests. I missed by a few commits only, so I did it by
> > hand.
> > 
> > The bad commit is f2b993d414517037cf064e9aed954cdae96646f5
> > 
> > commit f2b993d414517037cf064e9aed954cdae96646f5
> > Author: Alexandre Julliard <julliard at winehq.org>
> > Date:   Fri May 14 20:19:58 2010 +0200
> > 
> >     comctl32/imagelist: Pre-multiply the colors by the alpha channel when
> > storing an image with alpha.
> 
> mhhhh.... I guess that's not the right offending patch either.
> It should be somewhere in gdi32/winex11.drv.
> Anyways I posted a working version of the engine.... hopefully. For me it
> works,
> even if I had no time to locate the true problem.
> 

Well, I understand you did a dirty hack, so I was hoping I could help you (or
someone trying to locate the problem) to find it. It might be a bug with wine,
isn't it true?

Are you sure this is not the bad commit? I don't see what I have done wrong. I
did a git reset --hard f2b993d414517037cf064e9aed954cdae96646f5, patched,
compiled, and tested, it crashes. The commit before that is
5532927ed33f3682c48bdc2a2528488eeefa5bad (according to git log), so I reseted
to it, patched, compiled, tested and it works.

And I've just tested it again.

Here is the sequence of commands (careful, it deletes WINEPREFIX):

export WINEPREFIX=/home/gugamilare/.wine-test/
rm -rf dlls/winedib.drv/
git checkout -f
make clean
git reset --hard f2b993d414517037cf064e9aed954cdae96646f5
sh patches/series # I transformed the file "series" of the tarball into a
script
autoconf
CC="ccache gcc" ./configure && make depend && make
rm -rf $WINEPREFIX
./wine notepad # => works
rm -rf $WINEPREFIX
WINEDIB=ON ./wine notepad # => crashes

rm -rf dlls/winedib.drv/
git checkout -f
make clean
git reset --hard 5532927ed33f3682c48bdc2a2528488eeefa5bad
sh patches/series
autoconf
CC="ccache gcc" ./configure && make depend && make
rm -rf $WINEPREFIX
WINEDIB=ON ./wine notepad # => works

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.