[Bug 23355] Ring-Protech CD/DVD Protection fails

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=23355

Chris Parker <cparke at parkerfamily.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cparke at parkerfamily.name

--- Comment #5 from Chris Parker <cparke at parkerfamily.name> 2010-09-28 12:47:06 CDT ---
(In reply to comment #1)
> Patch sent http://www.winehq.org/pipermail/wine-patches/2010-July/090334.html
> but rejected because the only merit of reverting the offending commit is to
> make Ring-Protech work, without implementing correct behaviour for Wine.
> See discussion in
> http://www.winehq.org/pipermail/wine-devel/2010-July/084949.html
> about how to implement a correct GetVolumeInformation.
> Any volunteers?

The fix to volume.c by Guy Albertelli in 2009 was definitely misguided.  I know
he did it like the documentation asks, but that isn't how Windows actually
operates.  

Windows documentation says the trailing backslash is required, but it only
enforces that rule for fixed hard drives.  Floppy drives, CD-ROM drives, USB
flash drives, SUBST aliases (junction mounts), network drive shares don't need
the trailing backslash after the letter.  In most cases, it is not required,
and WINE is certainly broken on a lot of installers as long as that so-called
"fix" remains.  Many installers must be failing for odd reasons under WINE
because of our incompatibility on this function.  This is a very important
function to get correct, it's not a joke!  

In my case, I have an setup installer failing because it can't validate a copy
protection routine involving a key floppy diskette using
GetVolumeInformation().  WINE fails the request for retrieving the serial
number for "A:", but Windows returns it just fine.  Consequently, WINE causes
the copy protection routine to decide to reject my otherwise valid license
serial number.  Now I find out someone intentionally put this requirement in! 
It took me many hours last night with WinDbg to find out this was where the
real problem is (after all, I have to crack the copy protection to figure out
the problem).  

Please key this PATCH into the next release!

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.