[Bug 21387] NetTerm locks up

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=21387

--- Comment #13 from André H. <nerv at dawncrow.de> 2011-08-03 12:29:35 CDT ---
(In reply to comment #10)
> The make test for the sockets says there are 2 failures, both of them are
> success inside todo blocks, I'm not sure what that means but I guess they are
> not real errors.
> 
> sock.c:4979:  **** TEST 4 COMPLETE ****
> sock.c:2314: Test succeeded inside todo block: expected 0 (timeout), got: 0
> sock.c:2353: Test marked todo: select should not return any socket handles
> sock.c:2354: Test marked todo: FD should not be set
> sock.c:2355: Test succeeded inside todo block: FD should not be set

you already did a good job and the test proves that.
tests marked with todo_wine makes our test not fail when a check failed on
wine, so that we happily can test it on windows without being annoyed when
testing in wine.
that means your patch should also remove the todo_wine flags in these two
lines.
further your patch should be in git format, see 
http://wiki.winehq.org/SubmittingPatches

i didn't looked closer, so i bet you also should follow Dan's hints.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.