[Bug 8322] TaskCoach failed to view Menu bar and right click menu (user32.MENU_GetBitmapItemSize handles HBMMENU_CALLBACK case incorrectly)

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=8322

Anastasius Focht <focht at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |focht at gmx.net
          Component|-unknown                    |user32
            Summary|TaskCoach failed to view    |TaskCoach failed to view
                   |Menu bar and right click    |Menu bar and right click
                   |menu                        |menu
                   |                            |(user32.MENU_GetBitmapItemS
                   |                            |ize handles
                   |                            |HBMMENU_CALLBACK case
                   |                            |incorrectly)

--- Comment #13 from Anastasius Focht <focht at gmx.net> 2011-05-03 19:09:23 CDT ---
Hello,

confirming, still present.

$ wine --version
wine-1.3.19-100-ga343c1f

$ sha1sum TaskCoach-0.67.0-win32.exe 
aef9abff5fc45abb9cb079831c1e2b5c6a1a93a4  TaskCoach-0.67.0-win32.exe

Trace log snippet:

--- snip ---
...
0025:Ret  window proc 0xa015b0
(hwnd=0x2007c,msg=WM_INITMENUPOPUP,wp=000100f8,lp=00000007) retval=00000000
...
0025:Call window proc 0xa015b0
(hwnd=0x2007c,msg=WM_DRAWITEM,wp=00000000,lp=0032ddb8) 
...
0025:Call KERNEL32.OutputDebugStringW(01b01774 L"9:56:44 PM:
..\\..\\src\\msw\\ownerdrw.cpp(451): assert \"(nBmpWidth <= rc.GetWidth()) &&
(nBmpHeight <= rc.GetHeight())\" failed in wxOwnerDrawn::OnDrawItem().\r\n")
ret=00aaa771
0025:Ret  KERNEL32.OutputDebugStringW() retval=0032d3b0 ret=00aaa771 
--- snip ---

G00gling a bit, this thread came up:

http://wxpython-users.1045709.n5.nabble.com/C-assertion-in-PopupMenu-td2370887.html

--- quote ---
"I just received an
>> automated error report I've never seen before and can't seem to
>> reproduce on my system. 
"

"I'm on WinXP Service Pack 3, while this user is only on
Service Pack 2, so it still could be that your theory is correct if Microsoft
fixed something under the hood."
--- quote ---

Both developers - Paul McNett, author of the app and Robin Dunn, creator of
wxPython - didn't notice its actually Wine the app was run on ;-)

-> "Platform: 0.9.27 Windows-XP-5.1.2600-SP2"

The source code of the corresponding member function
wxOwnerDrawn::OnDrawItem(), where the assert appears:

http://trac.wxwidgets.org/browser/wxWidgets/branches/WX_2_8_BRANCH/src/msw/ownerdrw.cpp#L465