[Bug 29845] New: reserved identifier violation

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=29845

             Bug #: 29845
           Summary: reserved identifier violation
           Product: Wine
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: wine-bugs at winehq.org
        ReportedBy: Markus.Elfring at web.de
    Classification: Unclassified


I suggest to try the search pattern "\<_(?:(?:_(.*))|([A-Z]+))" on source
files. A couple of places will be found where names begin with two underscores
or an underscore and an uppercase letter.

Examples:
- __WINE_ACCCTRL_H
 
http://source.winehq.org/git/wine.git/blob/360a3f914235e04216a3691390662885c1867eb1:/include/accctrl.h#l19

- _SI_OBJECT_INFO
 
http://source.winehq.org/git/wine.git/blob/0453b03e86fb28f3f87f1a51c69946157f924168:/include/aclui.h#l30

- _Lockit
 
http://source.winehq.org/git/wine.git/blob/e3174d93d8c898ea6ecd9c8d8f9bb5b9ff41b9b2:/dlls/msvcp60/msvcp.h#l257


This usage does not fit to the expected naming conventions of the C language
standard.
https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.