[Bug 28170] "Text Service and Input Languages" crash: Unimplemented function USER32.dll.LoadKeyboardLayoutEx called

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=28170

Dmitry Timoshkov <dmitry at baikal.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #3 from Dmitry Timoshkov <dmitry at baikal.ru> 2012-01-03 22:12:14 CST ---
(In reply to comment #2)
> try this

> +HKL WINAPI LoadKeyboardLayoutEx(DWORD unknown, LPCWSTR pwszKLID, UINT Flags)
> +{
> +    FIXME("stub! (%d, %s, %d)\n", unknown, debugstr_w(pwszKLID), Flags);
> +    return FALSE;
> +}

1. Returning FALSE from an API supposed to return an HKL is wrong.
2. Why not simply forward it to a not Ex version, or better other way around?
3. It's not clear it this API should have both A and W versions and one of
them (which one?) have a shortcut to this one.
4. Is there any reason that you think it has unicode arg(s)?
5. Once again using hungarian style in Wine is something strongly discouraged.
6. Usually flags (and unknowns) are printed in hex.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.