[Bug 12401] Support junction points, i.e. DeviceIoCtl(FSCTL_SET_REPARSE_POINT/FSCTL_GET_REPARSE_POINT)

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=12401

Erich Hoover <ehoover at mines.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40600|0                           |1
        is obsolete|                            |

--- Comment #20 from Erich Hoover <ehoover at mines.edu> 2012-06-19 19:21:49 CDT ---
Created attachment 40614
  --> http://bugs.winehq.org/attachment.cgi?id=40614
Patch series to add support for junction points [v3]

I've attached an updated patch, see below.

(In reply to comment #19)
> ...
>  * do we really want to advertise junction point support for every fs? [1]

No, the way I currently have it we would only advertise support if the
filesystem is NOT one of the following: ISO9660, UDF, FAT16, or FAT32.  I
looked rather extensively at a way to test for symlink support and I've so far
been unable to find a way to do this without actually trying to create a link.

> ...
>  * test special cases not only create, read, delete per ioctl, but use e.g.
> DeleteFile() to delete the link and see what happens, delete the target and see
> what happens,

I've added several more test cases and spread them out throughout the patches
so that each case goes with the appropriate code.  This actually exposed a
problem that currently exists in deleting a symlink that's a folder, at this
time Wine fails to handle that properly (fix in patch 5).

> ...
>  * all these skip() makes me nervous, maybe some more win_skip() when
> appropriate. Further i think they can be reduced.

Please see if this version looks more acceptable.

>  ...
> Anyway, you did a good job.

Thanks!  I think the only thing that's not covered now is symlinks (Vista+
feature), but I figured that I should start with junction points first.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.