[Bug 31066] New: Avoid printing pServerPrincName with COLE_DEFAULT_PRINCIPAL ((OLECHAR *)-1) in IClientSecurity::SetBlanket stub FIXME

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=31066

             Bug #: 31066
           Summary: Avoid printing pServerPrincName with
                    COLE_DEFAULT_PRINCIPAL ((OLECHAR *)-1) in
                    IClientSecurity::SetBlanket stub FIXME
           Product: Wine
           Version: 1.5.7
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: wmi&wbemprox
        AssignedTo: wine-bugs at winehq.org
        ReportedBy: focht at gmx.net
    Classification: Unclassified


Hello,

not really a problem but a bit annoying in trace logs and debugger.

In certain situations IClientSecurity::SetBlanket() causes in internal
exception due to a non-string parameter in FIXME.
Handled gracefully but still noise.

--- snip ---
...
0032:trace:seh:raise_exception code=c0000005 flags=0 addr=0xf75cff96
ip=f75cff96 tid=0032
0032:trace:seh:raise_exception  info[0]=00000000
0032:trace:seh:raise_exception  info[1]=ffffffff
0032:trace:seh:raise_exception  eax=ffffffff ebx=f76fa984 ecx=9930105d
edx=f75cff1a esi=ffffffff edi=00bc0d38
0032:trace:seh:raise_exception  ebp=006dd63c esp=006dd604 cs=0023 ds=002b
es=002b fs=0063 gs=006b flags=00010246
0032:trace:seh:call_stack_handlers calling handler at 0x7bc92059 code=c0000005
flags=0
0032:trace:seh:__regs_RtlUnwind code=c0000005 flags=2
0032:trace:seh:__regs_RtlUnwind calling handler at 0x7bc770ff code=c0000005
flags=2
0032:trace:seh:__regs_RtlUnwind handler at 0x7bc770ff returned 1
0032:fixme:wbemprox:client_security_SetBlanket 0xf6f36f50, 0xbc0d38,
4294967295, 0, (invalid), 2, 3, (nil), 0x00000020
--- snip ---

The .NET code passes "COLE_DEFAULT_PRINCIPAL" as pServerPrincName which is
defined as ((OLECHAR *)-1).

Code:

http://source.winehq.org/git/wine.git/blob/0ceee481fe16ac6f731f4cb13717d5b404bb3147:/dlls/wbemprox/services.c#l98

--- snip ---
  98 static HRESULT WINAPI client_security_SetBlanket(
  99     IClientSecurity *iface,
 100     IUnknown *pProxy,
 101     DWORD AuthnSvc,
 102     DWORD AuthzSvc,
 103     OLECHAR *pServerPrincName,
 104     DWORD AuthnLevel,
 105     DWORD ImpLevel,
 106     void *pAuthInfo,
 107     DWORD Capabilities )
 108 {
 109     FIXME("%p, %p, %u, %u, %s, %u, %u, %p, 0x%08x\n", iface, pProxy,
AuthnSvc, AuthzSvc,
 110           debugstr_w(pServerPrincName), AuthnLevel, ImpLevel, pAuthInfo,
Capabilities);
 111     return WBEM_NO_ERROR;
 112 }
--- snip ---

Would be nice to avoid calling debugstr_w(-1) in that situation.

Regards

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.