[Bug 30639] Audio stuttering and performance drops in Star Wolves 3

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=30639

--- Comment #20 from Andrew Eikum <aeikum at codeweavers.com> 2012-05-14 08:14:28 CDT ---
I don't have any strong objections to your patch, but just some thoughts.

This adds another codepath, which makes me a little hesitant. Another method to
consider is using a lower resolution FIR, which lets us keep just the one
codepath. A "problem" here is module bloat. Two FIRs is going to make the
binary size quite large.

Does this handle adding/removing buffers? For example, if an app is playing and
adds a fourth buffer, does that transition happen correctly?

Instead of triggering the LQ resampler based on the number of buffers, what
about using the number of playing buffers? Some apps load lots of buffers, but
only play a couple at a time. This could make the previous problem occur more
often.

Finally, I'm wondering if fixing this bug should wait until after the rest of
my cleanup patches. This bug only has a small handful of applications listed,
and we've had no reports from other users or duplicates. It doesn't seem /that/
high priority to me.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.