[Bug 33055] Fishdom 2 crashes during the initial loading stage

wine-bugs at winehq.org wine-bugs at winehq.org
Thu Apr 4 09:47:59 CDT 2013


http://bugs.winehq.org/show_bug.cgi?id=33055

--- Comment #6 from Henri Verbeet <hverbeet at gmail.com> 2013-04-04 09:47:59 CDT ---
(In reply to comment #5)
> No, if we pass garbage to wined3d_device_set_texture it will crash there - this
> is where texture_impl->wined3d_texture points to, that's why I think we have to
> use NULL. The texture variable contains freed memory, which could be already
> overwritten. The game also crashes with your patch.
> 
The idea was to keep GetTexture() working as well, but that's not going to work
anyway because of the AddRef() in there, so NULL is probably the right thing to
return. It's a bit curious that it would work before
83761d20a8654a616b557ecdb2869436beae7f95 though, since it would pass the same
uninitialized memory to wined3d_device_set_texture() in that case.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list