[Bug 25082] radmin: right mouse key drag'n'drop not working

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=25082

--- Comment #14 from Nikolay Sivov <bunglehead at gmail.com> 2013-01-27 23:55:24 CST ---
(In reply to comment #13)
> Well, this should also work for these bugs. In order to be correct the code
> would have to take return value from NM_RCLICK into account. notify_click
> returns an information if the listview window still exists.

Yes, NM_RCLICK seems to be special case here, cause other notification don't
care about return value, well according to MSDN at least. It should be fixed
separately with another patch.

> 
> That return value is a huge pain. It was introduced by commit
> c0b79e0b055a0093ab1c2c129c593d74e51d3709, which was a hack intended to fix bug
> 3366, which was most likely a bug in comdlg. That hack is most likely not
> needed by any other application. Now there are multiple notify functions, and
> some return the result of SendMessage, others return the result of IsWindow,
> and you have to check each time. Do you think we could get rid of that IsWindow
> mess?

Well, to be sure it will need some test application for interactive testing.
For example if native reliably crashes if control is destroyed during NM_CLICK
and others we could remove that stuff.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.