[Bug 18517] Tablet pen pressure or eraser (wacom tablet) are not working in Photoshop CS 4/5

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=18517

--- Comment #35 from Bruno Jesus <00cpxxx at gmail.com> ---
(In reply to phaethon from comment #34)
> Created attachment 47818 [details]
> Final patch candidate

I think you should really send the last part as a separate patch. Since it's a
copy & paste issue the chances of getting it commited are much higher. The
first change of the patch also seems unrelated to the rest, so it could be a
different patch.

I can't comment the rest of the patch because I have no knowledge in that area,
I can just tell that some lines are too long in setChanged, maybe you could use
memcmp instead of comparing each individual part of the struct. And have a last
struct variable with all values inside instead of separate lastXXX variables.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.