Jacek Caban : mshtml: Improve ConfirmEx hack.

Alexandre Julliard julliard at wine.codeweavers.com
Tue Feb 28 06:07:46 CST 2006


Module: wine
Branch: refs/heads/master
Commit: a611b20c2621d4fccfa2b07d4ee357035b10e8db
URL:    http://source.winehq.org/git/?p=wine.git;a=commit;h=a611b20c2621d4fccfa2b07d4ee357035b10e8db

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Fri Feb 24 22:21:03 2006 +0100

mshtml: Improve ConfirmEx hack.

---

 dlls/mshtml/nsservice.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/dlls/mshtml/nsservice.c b/dlls/mshtml/nsservice.c
index 68b9de0..faa69ce 100644
--- a/dlls/mshtml/nsservice.c
+++ b/dlls/mshtml/nsservice.c
@@ -122,14 +122,14 @@ static nsresult NSAPI nsPromptService_Co
      * This is really very very ugly hack!!!
      */
 
-    if(!memcmp(aButton0Title, wszContinue, sizeof(wszContinue)))
+    if(aButton0Title && !memcmp(aButton0Title, wszContinue, sizeof(wszContinue)))
         *_retval = 0;
-    else if(!memcmp(aButton1Title, wszContinue, sizeof(wszContinue)))
+    else if(aButton1Title && !memcmp(aButton1Title, wszContinue, sizeof(wszContinue)))
         *_retval = 1;
-    else if(!memcmp(aButton2Title, wszContinue, sizeof(wszContinue)))
+    else if(aButton2Title && !memcmp(aButton2Title, wszContinue, sizeof(wszContinue)))
         *_retval = 2;
-    else
-        *_retval = 0;
+    /* else
+     *     let's hope that _retval is set to the default value */
 
     return NS_OK;
 }




More information about the wine-cvs mailing list