Robert Shearman : rpcrt4: Don't release the interface pointer on
failure.
Alexandre Julliard
julliard at wine.codeweavers.com
Tue Jan 10 14:14:06 CST 2006
Module: wine
Branch: refs/heads/master
Commit: e298538459acf2d5c96f762a1f863f286b375891
URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=e298538459acf2d5c96f762a1f863f286b375891
Author: Robert Shearman <rob at codeweavers.com>
Date: Tue Jan 10 19:59:26 2006 +0100
rpcrt4: Don't release the interface pointer on failure.
Don't release the interface pointer on failure since we are not the
ones that allocated it. It is the caller's responsability to call
NdrInterfacePointerFree, where the freeing is supposed to happen.
---
dlls/rpcrt4/ndr_ole.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/dlls/rpcrt4/ndr_ole.c b/dlls/rpcrt4/ndr_ole.c
index 0919f9f..5d7cccf 100644
--- a/dlls/rpcrt4/ndr_ole.c
+++ b/dlls/rpcrt4/ndr_ole.c
@@ -261,10 +261,8 @@ unsigned char * WINAPI NdrInterfacePoint
pStubMsg->dwDestContext, pStubMsg->pvDestContext,
MSHLFLAGS_NORMAL);
IStream_Release(stream);
- if (FAILED(hr)) {
- IUnknown_Release((LPUNKNOWN)pMemory);
+ if (FAILED(hr))
RpcRaiseException(hr);
- }
}
}
return NULL;
More information about the wine-cvs
mailing list