Rein Klazes : user: Avoid buffer overflow in sysparams.c.
Alexandre Julliard
julliard at wine.codeweavers.com
Mon Jan 16 14:37:54 CST 2006
Module: wine
Branch: refs/heads/master
Commit: de9400262e6187ef38a46b2bc1952d4ea399644d
URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=de9400262e6187ef38a46b2bc1952d4ea399644d
Author: Rein Klazes <wijn at wanadoo.nl>
Date: Mon Jan 16 20:41:57 2006 +0100
user: Avoid buffer overflow in sysparams.c.
Increase buffer size to 12 for getting and setting integer parameters
from/to the registry.
---
dlls/user/sysparams.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/dlls/user/sysparams.c b/dlls/user/sysparams.c
index dde61ff..900a499 100644
--- a/dlls/user/sysparams.c
+++ b/dlls/user/sysparams.c
@@ -748,7 +748,7 @@ static BOOL get_uint_param( unsigned int
if (!ret_ptr) return FALSE;
if (!spi_loaded[idx])
{
- WCHAR buf[10];
+ WCHAR buf[12];
if (SYSPARAMS_Load( regkey, value, buf, sizeof(buf) )) *value_ptr = atoiW( buf );
spi_loaded[idx] = TRUE;
@@ -764,7 +764,7 @@ static BOOL get_twips_param( unsigned in
if (!ret_ptr) return FALSE;
if (!spi_loaded[idx])
{
- WCHAR buf[10];
+ WCHAR buf[12];
if (SYSPARAMS_Load( regkey, value, buf, sizeof(buf) ))
*value_ptr = SYSPARAMS_Twips2Pixels( atoiW(buf) );
@@ -785,7 +785,7 @@ static inline BOOL get_bool_param( unsig
static BOOL set_uint_param_mirrored( unsigned int idx, LPCWSTR regkey, LPCWSTR regkey_mirror,
LPCWSTR value, UINT *value_ptr, UINT new_val, UINT fWinIni )
{
- WCHAR buf[10];
+ WCHAR buf[12];
wsprintfW(buf, CSu, new_val);
if (!SYSPARAMS_Save( regkey, value, buf, fWinIni )) return FALSE;
@@ -799,7 +799,7 @@ static BOOL set_uint_param_mirrored( uns
static BOOL save_int_param( LPCWSTR regkey, LPCWSTR value, INT *value_ptr,
INT new_val, UINT fWinIni )
{
- WCHAR buf[10];
+ WCHAR buf[12];
wsprintfW(buf, CSd, new_val);
if (!SYSPARAMS_Save( regkey, value, buf, fWinIni )) return FALSE;
@@ -1172,7 +1172,7 @@ BOOL WINAPI SystemParametersInfoW( UINT
spi_idx = SPI_SETMOUSE_IDX;
if (!spi_loaded[spi_idx])
{
- WCHAR buf[10];
+ WCHAR buf[12];
if (SYSPARAMS_Load( SPI_SETMOUSE_REGKEY, SPI_SETMOUSE_VALNAME1,
buf, sizeof(buf) ))
@@ -1278,7 +1278,7 @@ BOOL WINAPI SystemParametersInfoW( UINT
case SPI_SETSCREENSAVEACTIVE: /* 17 */
{
- WCHAR buf[5];
+ WCHAR buf[12];
wsprintfW(buf, CSu, uiParam);
USER_Driver->pSetScreenSaveActive( uiParam );
More information about the wine-cvs
mailing list