Robert Reif : dsound: Primary buffer size change tests.

Alexandre Julliard julliard at wine.codeweavers.com
Tue Jan 17 09:29:50 CST 2006


Module: wine
Branch: refs/heads/master
Commit: c82a63ba97d080e43aa61e408fc92f2fcc7222a8
URL:    http://source.winehq.org/git/?p=wine.git;a=commit;h=c82a63ba97d080e43aa61e408fc92f2fcc7222a8

Author: Robert Reif <reif at earthlink.net>
Date:   Tue Jan 17 16:19:54 2006 +0100

dsound: Primary buffer size change tests.
It looks like Windows doesn't change the primary buffer length when
changing formats so make the tests fail now.
This means the current ALSA implementation is broken when hardware
acceleration is set to full and the primary buffer format is changed.

---

 dlls/dsound/tests/ds3d.c  |   20 +++++++++-----------
 dlls/dsound/tests/ds3d8.c |   18 ++++++++----------
 2 files changed, 17 insertions(+), 21 deletions(-)

diff --git a/dlls/dsound/tests/ds3d.c b/dlls/dsound/tests/ds3d.c
index ea0a57c..ce7be84 100644
--- a/dlls/dsound/tests/ds3d.c
+++ b/dlls/dsound/tests/ds3d.c
@@ -410,20 +410,18 @@ void test_buffer(LPDIRECTSOUND dso, LPDI
             trace("    new Caps: flags=0x%08lx size=%ld\n",new_dsbcaps.dwFlags,
                   new_dsbcaps.dwBufferBytes);
         }
-                                                                                
+
         /* Check for primary buffer size change */
-        if (new_dsbcaps.dwBufferBytes != dsbcaps.dwBufferBytes) {
-            trace("    buffer size changed after SetFormat() - "
-                  "previous size was %lu, current size is %lu\n",
-                  dsbcaps.dwBufferBytes, new_dsbcaps.dwBufferBytes);
-        }
+        ok(new_dsbcaps.dwBufferBytes == dsbcaps.dwBufferBytes,
+           "    buffer size changed after SetFormat() - "
+           "previous size was %lu, current size is %lu\n",
+           dsbcaps.dwBufferBytes, new_dsbcaps.dwBufferBytes);
 
         /* Check for primary buffer flags change */
-        if (new_dsbcaps.dwFlags != dsbcaps.dwFlags) {
-            trace("    flags changed after SetFormat() - "
-                  "previous flags were %08lx, current flags are %08lx\n",
-                  dsbcaps.dwFlags, new_dsbcaps.dwFlags);
-        }
+        ok(new_dsbcaps.dwFlags == dsbcaps.dwFlags,
+           "    flags changed after SetFormat() - "
+           "previous flags were %08lx, current flags are %08lx\n",
+           dsbcaps.dwFlags, new_dsbcaps.dwFlags);
 
         /* Set the CooperativeLevel back to normal */
         /* DSOUND: Setting DirectSound cooperative level to DSSCL_NORMAL */
diff --git a/dlls/dsound/tests/ds3d8.c b/dlls/dsound/tests/ds3d8.c
index b01e4d0..6d440e2 100644
--- a/dlls/dsound/tests/ds3d8.c
+++ b/dlls/dsound/tests/ds3d8.c
@@ -304,18 +304,16 @@ void test_buffer8(LPDIRECTSOUND8 dso, LP
         }
 
         /* Check for primary buffer size change */
-        if (new_dsbcaps.dwBufferBytes != dsbcaps.dwBufferBytes) {
-            trace("    buffer size changed after SetFormat() - "
-                  "previous size was %lu, current size is %lu\n",
-                  dsbcaps.dwBufferBytes, new_dsbcaps.dwBufferBytes);
-        }
+        ok(new_dsbcaps.dwBufferBytes == dsbcaps.dwBufferBytes,
+           "    buffer size changed after SetFormat() - "
+           "previous size was %lu, current size is %lu\n",
+           dsbcaps.dwBufferBytes, new_dsbcaps.dwBufferBytes);
 
         /* Check for primary buffer flags change */
-        if (new_dsbcaps.dwFlags != dsbcaps.dwFlags) {
-            trace("    flags changed after SetFormat() - "
-                  "previous flags were %08lx, current flags are %08lx\n",
-                  dsbcaps.dwFlags, new_dsbcaps.dwFlags);
-        }
+        ok(new_dsbcaps.dwFlags == dsbcaps.dwFlags,
+           "    flags changed after SetFormat() - "
+           "previous flags were %08lx, current flags are %08lx\n",
+           dsbcaps.dwFlags, new_dsbcaps.dwFlags);
 
         /* Set the CooperativeLevel back to normal */
         /* DSOUND: Setting DirectSound cooperative level to DSSCL_NORMAL */




More information about the wine-cvs mailing list