Robert Shearman : msi: Only print fixme for progress attribute once.
Alexandre Julliard
julliard at wine.codeweavers.com
Mon Jan 23 05:05:25 CST 2006
Module: wine
Branch: refs/heads/master
Commit: 33fa9d08dd02ddcd4ac05ee61f2f1b907600dd94
URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=33fa9d08dd02ddcd4ac05ee61f2f1b907600dd94
Author: Robert Shearman <rob at codeweavers.com>
Date: Mon Jan 23 11:55:19 2006 +0100
msi: Only print fixme for progress attribute once.
Since setting the Progress attribute is done quite frequently, don't
flood the user with messages about it being unimplemented.
---
dlls/msi/dialog.c | 26 +++++++++++++++++++-------
1 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/dlls/msi/dialog.c b/dlls/msi/dialog.c
index 76d4d06..c3b305e 100644
--- a/dlls/msi/dialog.c
+++ b/dlls/msi/dialog.c
@@ -111,6 +111,7 @@ const WCHAR szMsiHiddenWindow[] = {
static const WCHAR szStatic[] = { 'S','t','a','t','i','c',0 };
static const WCHAR szButton[] = { 'B','U','T','T','O','N', 0 };
static const WCHAR szButtonData[] = { 'M','S','I','D','A','T','A',0 };
+static const WCHAR szProgress[] = { 'P','r','o','g','r','e','s','s',0 };
static const WCHAR szText[] = { 'T','e','x','t',0 };
static const WCHAR szPushButton[] = { 'P','u','s','h','B','u','t','t','o','n',0 };
static const WCHAR szLine[] = { 'L','i','n','e',0 };
@@ -467,16 +468,27 @@ void msi_dialog_handle_event( msi_dialog
ctrl = msi_dialog_find_control( dialog, control );
if (!ctrl)
return;
- if( lstrcmpW(attribute, szText) )
+ if( !lstrcmpW(attribute, szText) )
{
- ERR("Attribute %s\n", debugstr_w(attribute));
+ font_text = MSI_RecordGetString( rec , 1 );
+ font = msi_dialog_get_style( font_text, &text );
+ SetWindowTextW( ctrl->hwnd, text );
+ msi_free( font );
+ msi_dialog_check_messages( NULL );
+ }
+ else if( !lstrcmpW(attribute, szProgress) )
+ {
+ /* FIXME: should forward to progress bar */
+ static int display_fixme = 1;
+ if (display_fixme)
+ FIXME("Attribute %s not being set\n", debugstr_w(attribute));
+ display_fixme = 0;
+ }
+ else
+ {
+ FIXME("Attribute %s not being set\n", debugstr_w(attribute));
return;
}
- font_text = MSI_RecordGetString( rec , 1 );
- font = msi_dialog_get_style( font_text, &text );
- SetWindowTextW( ctrl->hwnd, text );
- msi_free( font );
- msi_dialog_check_messages( NULL );
}
static void msi_dialog_map_events(msi_dialog* dialog, LPCWSTR control)
More information about the wine-cvs
mailing list