Mike McCormack : taskmgr: Eliminate common code and fix a warning.
Alexandre Julliard
julliard at wine.codeweavers.com
Mon Mar 20 15:36:23 CST 2006
Module: wine
Branch: refs/heads/master
Commit: 1e27e1d584f1affdfbbf317e4e445822088e5db2
URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=1e27e1d584f1affdfbbf317e4e445822088e5db2
Author: Mike McCormack <mike at codeweavers.com>
Date: Mon Mar 20 22:36:13 2006 +0900
taskmgr: Eliminate common code and fix a warning.
---
programs/taskmgr/priority.c | 236 ++-----------------------------------------
1 files changed, 13 insertions(+), 223 deletions(-)
diff --git a/programs/taskmgr/priority.c b/programs/taskmgr/priority.c
index 7f76289..87a9d08 100644
--- a/programs/taskmgr/priority.c
+++ b/programs/taskmgr/priority.c
@@ -33,7 +33,7 @@
#include "taskmgr.h"
#include "perfdata.h"
-void ProcessPage_OnSetPriorityRealTime(void)
+static void DoSetPriority(DWORD priority)
{
LVITEM lvitem;
ULONG Index;
@@ -49,7 +49,7 @@ void ProcessPage_OnSetPriorityRealTime(v
lvitem.stateMask = LVIS_SELECTED;
lvitem.iItem = Index;
- ListView_GetItem(hProcessPageListCtrl, &lvitem);
+ SendMessage(hProcessPageListCtrl, LVM_GETITEM, 0, (LPARAM)&lvitem);
if (lvitem.state & LVIS_SELECTED)
break;
@@ -72,7 +72,7 @@ void ProcessPage_OnSetPriorityRealTime(v
return;
}
- if (!SetPriorityClass(hProcess, REALTIME_PRIORITY_CLASS))
+ if (!SetPriorityClass(hProcess, priority))
{
GetLastErrorText(strErrorText, 260);
MessageBox(hMainWnd, strErrorText, _T("Unable to Change Priority"), MB_OK|MB_ICONSTOP);
@@ -81,242 +81,32 @@ void ProcessPage_OnSetPriorityRealTime(v
CloseHandle(hProcess);
}
-void ProcessPage_OnSetPriorityHigh(void)
+void ProcessPage_OnSetPriorityRealTime(void)
{
- LVITEM lvitem;
- ULONG Index;
- DWORD dwProcessId;
- HANDLE hProcess;
- TCHAR strErrorText[260];
-
- for (Index=0; Index<(ULONG)ListView_GetItemCount(hProcessPageListCtrl); Index++)
- {
- memset(&lvitem, 0, sizeof(LVITEM));
-
- lvitem.mask = LVIF_STATE;
- lvitem.stateMask = LVIS_SELECTED;
- lvitem.iItem = Index;
-
- ListView_GetItem(hProcessPageListCtrl, &lvitem);
-
- if (lvitem.state & LVIS_SELECTED)
- break;
- }
-
- dwProcessId = PerfDataGetProcessId(Index);
-
- if ((ListView_GetSelectedCount(hProcessPageListCtrl) != 1) || (dwProcessId == 0))
- return;
-
- if (MessageBox(hMainWnd, _T("WARNING: Changing the priority class of this process may\ncause undesired results including system instability. Are you\nsure you want to change the priority class?"), _T("Task Manager Warning"), MB_YESNO|MB_ICONWARNING) != IDYES)
- return;
-
- hProcess = OpenProcess(PROCESS_SET_INFORMATION, FALSE, dwProcessId);
-
- if (!hProcess)
- {
- GetLastErrorText(strErrorText, 260);
- MessageBox(hMainWnd, strErrorText, _T("Unable to Change Priority"), MB_OK|MB_ICONSTOP);
- return;
- }
-
- if (!SetPriorityClass(hProcess, HIGH_PRIORITY_CLASS))
- {
- GetLastErrorText(strErrorText, 260);
- MessageBox(hMainWnd, strErrorText, _T("Unable to Change Priority"), MB_OK|MB_ICONSTOP);
- }
+ DoSetPriority(REALTIME_PRIORITY_CLASS);
+}
- CloseHandle(hProcess);
+void ProcessPage_OnSetPriorityHigh(void)
+{
+ DoSetPriority(HIGH_PRIORITY_CLASS);
}
void ProcessPage_OnSetPriorityAboveNormal(void)
{
- LVITEM lvitem;
- ULONG Index;
- DWORD dwProcessId;
- HANDLE hProcess;
- TCHAR strErrorText[260];
-
- for (Index=0; Index<(ULONG)ListView_GetItemCount(hProcessPageListCtrl); Index++)
- {
- memset(&lvitem, 0, sizeof(LVITEM));
-
- lvitem.mask = LVIF_STATE;
- lvitem.stateMask = LVIS_SELECTED;
- lvitem.iItem = Index;
-
- ListView_GetItem(hProcessPageListCtrl, &lvitem);
-
- if (lvitem.state & LVIS_SELECTED)
- break;
- }
-
- dwProcessId = PerfDataGetProcessId(Index);
-
- if ((ListView_GetSelectedCount(hProcessPageListCtrl) != 1) || (dwProcessId == 0))
- return;
-
- if (MessageBox(hMainWnd, _T("WARNING: Changing the priority class of this process may\ncause undesired results including system instability. Are you\nsure you want to change the priority class?"), _T("Task Manager Warning"), MB_YESNO|MB_ICONWARNING) != IDYES)
- return;
-
- hProcess = OpenProcess(PROCESS_SET_INFORMATION, FALSE, dwProcessId);
-
- if (!hProcess)
- {
- GetLastErrorText(strErrorText, 260);
- MessageBox(hMainWnd, strErrorText, _T("Unable to Change Priority"), MB_OK|MB_ICONSTOP);
- return;
- }
-
- if (!SetPriorityClass(hProcess, ABOVE_NORMAL_PRIORITY_CLASS))
- {
- GetLastErrorText(strErrorText, 260);
- MessageBox(hMainWnd, strErrorText, _T("Unable to Change Priority"), MB_OK|MB_ICONSTOP);
- }
-
- CloseHandle(hProcess);
+ DoSetPriority(ABOVE_NORMAL_PRIORITY_CLASS);
}
void ProcessPage_OnSetPriorityNormal(void)
{
- LVITEM lvitem;
- ULONG Index;
- DWORD dwProcessId;
- HANDLE hProcess;
- TCHAR strErrorText[260];
-
- for (Index=0; Index<(ULONG)ListView_GetItemCount(hProcessPageListCtrl); Index++)
- {
- memset(&lvitem, 0, sizeof(LVITEM));
-
- lvitem.mask = LVIF_STATE;
- lvitem.stateMask = LVIS_SELECTED;
- lvitem.iItem = Index;
-
- ListView_GetItem(hProcessPageListCtrl, &lvitem);
-
- if (lvitem.state & LVIS_SELECTED)
- break;
- }
-
- dwProcessId = PerfDataGetProcessId(Index);
-
- if ((ListView_GetSelectedCount(hProcessPageListCtrl) != 1) || (dwProcessId == 0))
- return;
-
- if (MessageBox(hMainWnd, _T("WARNING: Changing the priority class of this process may\ncause undesired results including system instability. Are you\nsure you want to change the priority class?"), _T("Task Manager Warning"), MB_YESNO|MB_ICONWARNING) != IDYES)
- return;
-
- hProcess = OpenProcess(PROCESS_SET_INFORMATION, FALSE, dwProcessId);
-
- if (!hProcess)
- {
- GetLastErrorText(strErrorText, 260);
- MessageBox(hMainWnd, strErrorText, _T("Unable to Change Priority"), MB_OK|MB_ICONSTOP);
- return;
- }
-
- if (!SetPriorityClass(hProcess, NORMAL_PRIORITY_CLASS))
- {
- GetLastErrorText(strErrorText, 260);
- MessageBox(hMainWnd, strErrorText, _T("Unable to Change Priority"), MB_OK|MB_ICONSTOP);
- }
-
- CloseHandle(hProcess);
+ DoSetPriority(NORMAL_PRIORITY_CLASS);
}
void ProcessPage_OnSetPriorityBelowNormal(void)
{
- LVITEM lvitem;
- ULONG Index;
- DWORD dwProcessId;
- HANDLE hProcess;
- TCHAR strErrorText[260];
-
- for (Index=0; Index<(ULONG)ListView_GetItemCount(hProcessPageListCtrl); Index++)
- {
- memset(&lvitem, 0, sizeof(LVITEM));
-
- lvitem.mask = LVIF_STATE;
- lvitem.stateMask = LVIS_SELECTED;
- lvitem.iItem = Index;
-
- ListView_GetItem(hProcessPageListCtrl, &lvitem);
-
- if (lvitem.state & LVIS_SELECTED)
- break;
- }
-
- dwProcessId = PerfDataGetProcessId(Index);
-
- if ((ListView_GetSelectedCount(hProcessPageListCtrl) != 1) || (dwProcessId == 0))
- return;
-
- if (MessageBox(hMainWnd, _T("WARNING: Changing the priority class of this process may\ncause undesired results including system instability. Are you\nsure you want to change the priority class?"), _T("Task Manager Warning"), MB_YESNO|MB_ICONWARNING) != IDYES)
- return;
-
- hProcess = OpenProcess(PROCESS_SET_INFORMATION, FALSE, dwProcessId);
-
- if (!hProcess)
- {
- GetLastErrorText(strErrorText, 260);
- MessageBox(hMainWnd, strErrorText, _T("Unable to Change Priority"), MB_OK|MB_ICONSTOP);
- return;
- }
-
- if (!SetPriorityClass(hProcess, BELOW_NORMAL_PRIORITY_CLASS))
- {
- GetLastErrorText(strErrorText, 260);
- MessageBox(hMainWnd, strErrorText, _T("Unable to Change Priority"), MB_OK|MB_ICONSTOP);
- }
-
- CloseHandle(hProcess);
+ DoSetPriority(BELOW_NORMAL_PRIORITY_CLASS);
}
void ProcessPage_OnSetPriorityLow(void)
{
- LVITEM lvitem;
- ULONG Index;
- DWORD dwProcessId;
- HANDLE hProcess;
- TCHAR strErrorText[260];
-
- for (Index=0; Index<(ULONG)ListView_GetItemCount(hProcessPageListCtrl); Index++)
- {
- memset(&lvitem, 0, sizeof(LVITEM));
-
- lvitem.mask = LVIF_STATE;
- lvitem.stateMask = LVIS_SELECTED;
- lvitem.iItem = Index;
-
- ListView_GetItem(hProcessPageListCtrl, &lvitem);
-
- if (lvitem.state & LVIS_SELECTED)
- break;
- }
-
- dwProcessId = PerfDataGetProcessId(Index);
-
- if ((ListView_GetSelectedCount(hProcessPageListCtrl) != 1) || (dwProcessId == 0))
- return;
-
- if (MessageBox(hMainWnd, _T("WARNING: Changing the priority class of this process may\ncause undesired results including system instability. Are you\nsure you want to change the priority class?"), _T("Task Manager Warning"), MB_YESNO|MB_ICONWARNING) != IDYES)
- return;
-
- hProcess = OpenProcess(PROCESS_SET_INFORMATION, FALSE, dwProcessId);
-
- if (!hProcess)
- {
- GetLastErrorText(strErrorText, 260);
- MessageBox(hMainWnd, strErrorText, _T("Unable to Change Priority"), MB_OK|MB_ICONSTOP);
- return;
- }
-
- if (!SetPriorityClass(hProcess, IDLE_PRIORITY_CLASS))
- {
- GetLastErrorText(strErrorText, 260);
- MessageBox(hMainWnd, strErrorText, _T("Unable to Change Priority"), MB_OK|MB_ICONSTOP);
- }
-
- CloseHandle(hProcess);
+ DoSetPriority(IDLE_PRIORITY_CLASS);
}
More information about the wine-cvs
mailing list