Paul Vriens : rsaenh: Move type-check before len-check (Coverity).

Alexandre Julliard julliard at wine.codeweavers.com
Mon Nov 13 06:32:16 CST 2006


Module: wine
Branch: master
Commit: 9fa27f3be3f45a211aec7cb0d56a8d3ddf1eb65b
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=9fa27f3be3f45a211aec7cb0d56a8d3ddf1eb65b

Author: Paul Vriens <paul.vriens.wine at gmail.com>
Date:   Sun Nov 12 17:55:09 2006 +0100

rsaenh: Move type-check before len-check (Coverity).

---

 dlls/rsaenh/rsa.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/dlls/rsaenh/rsa.c b/dlls/rsaenh/rsa.c
index 4d6cd03..00a65e5 100644
--- a/dlls/rsaenh/rsa.c
+++ b/dlls/rsaenh/rsa.c
@@ -62,12 +62,6 @@ int rand_prime(mp_int *N, long len)
 {
    int type;
 
-   /* allow sizes between 2 and 256 bytes for a prime size */
-   if (len < 16 || len > 8192) {
-	  printf("Invalid prime size!\n");
-      return CRYPT_INVALID_PRIME_SIZE;
-   }
-   
    /* get type */
    if (len < 0) {
       type = LTM_PRIME_BBS;
@@ -78,6 +72,12 @@ int rand_prime(mp_int *N, long len)
       /* Original LibTomCrypt: type = 0; */
    }
 
+   /* allow sizes between 2 and 256 bytes for a prime size */
+   if (len < 16 || len > 8192) {
+      printf("Invalid prime size!\n");
+      return CRYPT_INVALID_PRIME_SIZE;
+   }
+   
    /* New prime generation makes the code even more cryptoish-insane.  Do you know what this means!!!
       -- Gir:  Yeah, oh wait, er, no.
     */




More information about the wine-cvs mailing list