Mike McCormack : msi: Only free a string in one place.

Alexandre Julliard julliard at wine.codeweavers.com
Mon Nov 13 06:38:45 CST 2006


Module: wine
Branch: master
Commit: 4811743b36fae0cb9099d6d4ed1e663a61b42fc2
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=4811743b36fae0cb9099d6d4ed1e663a61b42fc2

Author: Mike McCormack <mike at codeweavers.com>
Date:   Mon Nov 13 16:35:59 2006 +0900

msi: Only free a string in one place.

---

 dlls/msi/custom.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c
index 2dea170..6ec4bb3 100644
--- a/dlls/msi/custom.c
+++ b/dlls/msi/custom.c
@@ -561,7 +561,7 @@ static UINT HANDLE_CustomType2(MSIPACKAG
     PROCESS_INFORMATION info;
     BOOL rc;
     INT len;
-    WCHAR *deformated;
+    WCHAR *deformated = NULL;
     WCHAR *cmd;
     static const WCHAR spc[] = {' ',0};
     UINT r = ERROR_SUCCESS;
@@ -595,15 +595,13 @@ static UINT HANDLE_CustomType2(MSIPACKAG
 
     rc = CreateProcessW(NULL, cmd, NULL, NULL, FALSE, 0, NULL,
                   c_collen, &si, &info);
-
+    msi_free(cmd);
 
     if ( !rc )
     {
         ERR("Unable to execute command %s\n", debugstr_w(cmd));
-        msi_free(cmd);
         return ERROR_SUCCESS;
     }
-    msi_free(cmd);
 
     r = process_handle(package, type, info.hThread, info.hProcess, action,
                           &finished);




More information about the wine-cvs mailing list