Mike McCormack : msi: Fix a memory leak in load_folder().

Alexandre Julliard julliard at wine.codeweavers.com
Fri Nov 17 04:54:15 CST 2006


Module: wine
Branch: master
Commit: eba742e5cdfd534f918fa560a50d439c9ffa8d3b
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=eba742e5cdfd534f918fa560a50d439c9ffa8d3b

Author: Mike McCormack <mike at codeweavers.com>
Date:   Fri Nov 17 17:50:41 2006 +0900

msi: Fix a memory leak in load_folder().

---

 dlls/msi/action.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index 7dcb375..1a13fb7 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -1527,16 +1527,16 @@ static MSIFOLDER *load_folder( MSIPACKAG
 
     TRACE("Working to load %s\n",debugstr_w(dir));
 
+    row = MSI_QueryGetRecord(package->db, Query, dir);
+    if (!row)
+        return NULL;
+
     folder = msi_alloc_zero( sizeof (MSIFOLDER) );
     if (!folder)
         return NULL;
 
     folder->Directory = strdupW(dir);
 
-    row = MSI_QueryGetRecord(package->db, Query, dir);
-    if (!row)
-        return NULL;
-
     p = msi_dup_record_field(row, 3);
 
     /* split src and target dir */




More information about the wine-cvs mailing list