Markus Amsler : d3d: Remove AddRef from IWineD3DDevice_GetRenderTarget.

Alexandre Julliard julliard at wine.codeweavers.com
Wed Nov 22 05:21:26 CST 2006


Module: wine
Branch: master
Commit: a7518f6f5494558e80ad125d0b42a46b4744d448
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=a7518f6f5494558e80ad125d0b42a46b4744d448

Author: Markus Amsler <markus.amsler at oribi.org>
Date:   Mon Nov 20 10:47:43 2006 +0100

d3d: Remove AddRef from IWineD3DDevice_GetRenderTarget.

---

 dlls/d3d8/device.c    |    1 -
 dlls/d3d9/device.c    |    1 -
 dlls/wined3d/device.c |    4 +---
 3 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c
index 429b918..0baa5ac 100644
--- a/dlls/d3d8/device.c
+++ b/dlls/d3d8/device.c
@@ -677,7 +677,6 @@ static HRESULT  WINAPI  IDirect3DDevice8
 
     if (hr == D3D_OK && pRenderTarget != NULL) {
         IWineD3DResource_GetParent((IWineD3DResource *)pRenderTarget,(IUnknown**)ppRenderTarget);
-        IWineD3DResource_Release((IWineD3DResource *)pRenderTarget);
     } else {
         FIXME("Call to IWineD3DDevice_GetRenderTarget failed\n");
         *ppRenderTarget = NULL;
diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c
index 8ed7b8d..9b31289 100644
--- a/dlls/d3d9/device.c
+++ b/dlls/d3d9/device.c
@@ -403,7 +403,6 @@ static HRESULT  WINAPI  IDirect3DDevice9
 
     if (hr == D3D_OK && pRenderTarget != NULL) {
         IWineD3DResource_GetParent((IWineD3DResource *)pRenderTarget,(IUnknown**)ppRenderTarget);
-        IWineD3DResource_Release((IWineD3DResource *)pRenderTarget);
     } else {
         FIXME("Call to IWineD3DDevice_GetRenderTarget failed\n");
         *ppRenderTarget = NULL;
diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c
index 1815e26..a42d91c 100644
--- a/dlls/wined3d/device.c
+++ b/dlls/wined3d/device.c
@@ -6889,9 +6889,7 @@ static HRESULT  WINAPI  IWineD3DDeviceIm
 
     *ppRenderTarget = This->renderTarget;
     TRACE("(%p) : RenderTarget %d Index returning %p\n", This, RenderTargetIndex, *ppRenderTarget);
-    /* Note inc ref on returned surface */
-    if(*ppRenderTarget != NULL)
-        IWineD3DSurface_AddRef(*ppRenderTarget);
+
     return WINED3D_OK;
 }
 




More information about the wine-cvs mailing list