James Hawkins : advapi32: Remove redundant NULL check before SERV_free ( found by Smatch).

Alexandre Julliard julliard at wine.codeweavers.com
Fri Oct 6 13:37:10 CDT 2006


Module: wine
Branch: master
Commit: ca118989f454554f6913337cca272a925653d0db
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=ca118989f454554f6913337cca272a925653d0db

Author: James Hawkins <truiken at gmail.com>
Date:   Thu Oct  5 19:38:07 2006 -0700

advapi32: Remove redundant NULL check before SERV_free (found by Smatch).

---

 dlls/advapi32/service.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c
index be0f41f..b1d80dc 100644
--- a/dlls/advapi32/service.c
+++ b/dlls/advapi32/service.c
@@ -433,8 +433,7 @@ static BOOL service_handle_start(HANDLE 
         goto end;
     }
 
-    if (service->args)
-        SERV_free(service->args);
+    SERV_free(service->args);
     service->args = args;
     args = NULL;
     service->thread = CreateThread( NULL, 0, service_thread,




More information about the wine-cvs mailing list